Prince John is rather elusive in the US Parks. Your best bet to find him is the Animation Building in Disney's Hollywood Studios at Walt Disney World during the later afternoon or early evening.
Luckily he can be found fairly regularly in Disneyland Paris. The most common places to find him are in Fantasyland near it's a small world and in Cafe Mickeys.